fix: implement caching on the card state for person card#3266
Merged
Conversation
The calls will respond with network data or cache data. If no cache is found, it loads from network then creates the cache
Collaborator
|
I'd suggest just polling card messages and any other more dynamic data section; I think the invalidation period for other sections like profiles and direct reports is sufficient. |
Contributor
Author
I like this idea. Can we do this as a feature on its own? It'll allow more introspection into areas we need to apply it as well as consequences around performance. |
Mnickii
approved these changes
Aug 6, 2024
|
📖 The updated storybook is available here |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3260
PR Type
Description of the changes
person-cardattribute set, do a call for card state batches . This will hit the cache first, if no cache is found, the network call is made and the response is cached. This enable any person card interaction on person to be faster as the data is already in cache.PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information
Maybe cache to a lower time limit to avoid stale data on updated sections like
messages?