Skip to content

fix: show login component flyout on after login#3250

Merged
Mnickii merged 1 commit intomicrosoftgraph:mainfrom
tavikukko:bugs/fix-login-component-flyout-bug
Jul 9, 2024
Merged

fix: show login component flyout on after login#3250
Mnickii merged 1 commit intomicrosoftgraph:mainfrom
tavikukko:bugs/fix-login-component-flyout-bug

Conversation

@tavikukko
Copy link
Copy Markdown
Contributor

Closes #3249

PR Type

  • Bugfix

Description of the changes

Fixes issue in login component when flyout stops working after relogin. Also refactored logout method order of getActiveAccount call.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@tavikukko tavikukko requested a review from a team as a code owner July 5, 2024 18:46
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Thank you for creating a Pull Request @tavikukko.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Copy link
Copy Markdown
Collaborator

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mnickii Mnickii changed the title fix login component flyout bug fix: show login component flyout on after login Jul 9, 2024
@Mnickii Mnickii added this to the 4.2.4 milestone Jul 9, 2024
@Mnickii Mnickii merged commit 62b1ed4 into microsoftgraph:main Jul 9, 2024
@Mnickii Mnickii removed this from the 4.2.4 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] mgt-login component flyout stops working after logout and relogin

2 participants