Skip to content

fix: display only a person's shared files in mgt-person-card#3238

Merged
Mnickii merged 8 commits intomainfrom
fix/bug-3232
Jul 1, 2024
Merged

fix: display only a person's shared files in mgt-person-card#3238
Mnickii merged 8 commits intomainfrom
fix/bug-3232

Conversation

@Mnickii
Copy link
Copy Markdown
Collaborator

@Mnickii Mnickii commented Jun 26, 2024 •
edited
Loading

Closes #3232

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 26, 2024 16:40
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service Bot commented Jun 26, 2024

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

musale
musale reviewed Jun 27, 2024
View reviewed changes
Comment thread packages/mgt-components/src/components/mgt-file-list/mgt-file-list.ts Outdated
musale
musale reviewed Jun 27, 2024
View reviewed changes
Comment thread packages/mgt-components/src/components/mgt-file-list/mgt-file-list.ts Outdated
musale
musale reviewed Jun 27, 2024
View reviewed changes
Comment thread packages/mgt-components/src/components/mgt-file-list/mgt-file-list.scss Outdated
musale
musale reviewed Jun 27, 2024
View reviewed changes
Comment thread packages/mgt-components/src/components/mgt-file-list/mgt-file-list.scss Outdated
Mnickii and others added 2 commits June 27, 2024 14:30
@Mnickii
remove inintended click events, apply review suggestions
3969b12
@Mnickii @musale
Update packages/mgt-components/src/components/mgt-file-list/mgt-file-…
2cc7fb7 
…list.ts


Use a more desciptive name

Co-authored-by: Musale Martin <martinmusale@microsoft.com>
@Mnickii Mnickii requested a review from musale June 27, 2024 11:32
musale
musale reviewed Jun 28, 2024
View reviewed changes
Comment thread packages/mgt-components/src/components/mgt-file-list/mgt-file-list.ts Outdated
musale
musale previously approved these changes Jun 28, 2024
View reviewed changes
@Mnickii Mnickii requested a review from musale June 28, 2024 12:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 1, 2024

📖 The updated storybook is available here

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
49.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Mnickii Mnickii merged commit da90c5b into main Jul 1, 2024
@Mnickii Mnickii deleted the fix/bug-3232 branch July 1, 2024 13:06
@gavinbarron gavinbarron mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@musale musale Awaiting requested review from musale

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@ElinorW ElinorW Awaiting requested review from ElinorW

1 more reviewer

@Michael-Wamae Michael-Wamae Michael-Wamae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Person card - Navigating to another user shows the same files

3 participants

@Mnickii @musale @Michael-Wamae