Skip to content

fix(a11y): add stackblitz button styling for high contrast theming#3213

Merged
Mnickii merged 6 commits intomainfrom
fix/bug-3078
Jun 13, 2024
Merged

fix(a11y): add stackblitz button styling for high contrast theming#3213
Mnickii merged 6 commits intomainfrom
fix/bug-3078

Conversation

@Mnickii
Copy link
Copy Markdown
Collaborator

@Mnickii Mnickii commented Jun 12, 2024 •
edited
Loading

Closes #3078

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 12, 2024 13:44
@Mnickii Mnickii changed the title fix(a11y): add forced colors to fix theming in high contrast in storybook editor fix(a11y): add stackblitz button styling for high contrast theming Jun 12, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 12, 2024

📖 The updated storybook is available here

@Mnickii
Copy link
Copy Markdown
Collaborator Author

Mnickii commented Jun 12, 2024

Hi @Raisul123 , @vagpt , this is ready for review.

gavinbarron
gavinbarron requested changes Jun 12, 2024
View reviewed changes
Comment thread .storybook/addons/codeEditorAddon/editor.js Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Author Feedback Issue needs response from issue author label Jun 12, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 12, 2024

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs: Author Feedback Issue needs response from issue author label Jun 13, 2024
@Mnickii Mnickii requested a review from gavinbarron June 13, 2024 08:34
@vagpt
Copy link
Copy Markdown
Collaborator

vagpt commented Jun 13, 2024

This issue is working fine on the URL below, hence we are good to close the bug related to this PR.

URL:

https://mgt.dev/next/pr/3213/?path=/story/editor--editor

Snippet:

image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 13, 2024

📖 The updated storybook is available here

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Mnickii Mnickii merged commit cb7621a into main Jun 13, 2024
@Mnickii Mnickii deleted the fix/bug-3078 branch June 13, 2024 16:00
@gavinbarron gavinbarron mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

+1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Accessibility Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

4 participants

@Mnickii @vagpt @gavinbarron @musale