Skip to content

fix: add userPrincipalName as an option in findPeople query#3206

Merged
musale merged 1 commit intomainfrom
fix/alt-option-for-unlicensed-users
Jun 10, 2024
Merged

fix: add userPrincipalName as an option in findPeople query#3206
musale merged 1 commit intomainfrom
fix/alt-option-for-unlicensed-users

Conversation

@musale
Copy link
Copy Markdown
Contributor

@musale musale commented Jun 10, 2024

Closes #3149

PR Type

  • Bugfix

Description of the changes

This allows to have another parameter for searching people in /users endpoint when the user is not licensed

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

This allows to have another parameter for searching people in /users endpoint when the user is not licensed

Signed-off-by: Musale Martin <martinmusale@microsoft.com>
@musale musale requested a review from a team as a code owner June 10, 2024 09:54
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link
Copy Markdown

📖 The updated storybook is available here

1 similar comment
@github-actions
Copy link
Copy Markdown

📖 The updated storybook is available here

@sonarqubecloud
Copy link
Copy Markdown

@musale musale merged commit 97fe1c0 into main Jun 10, 2024
@musale musale deleted the fix/alt-option-for-unlicensed-users branch June 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] mgt-person not working for unlicenced users (users without email)

2 participants