fix(a11y): focus on uploaded file and narrate status#3189
Merged
Conversation
Contributor
|
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
Contributor
Author
|
@vagpt review this for a11y |
Mnickii
requested changes
May 27, 2024
Collaborator
Mnickii
left a comment
There was a problem hiding this comment.
let's use uploadDom as a HTMLElement to be able to call focus() on it.
Co-authored-by: Nickii Miaro <miaronkirote@gmail.com>
|
📖 The updated storybook is available here |
|
📖 The updated storybook is available here |
|
📖 The updated storybook is available here |
Collaborator
|
This issue is still repro on the URL below. Attachment is added for the reference. URL: https://mgt.dev/next/pr/3189/?path=/story/components-mgt-file-list-properties--file-list-upload Attachment: Issue.is.still.repro.at.SR.is.still.not.announicng.any.infomration.mp4 |
|
📖 The updated storybook is available here |
Contributor
Author
|
@vagpt please hard reload and test again, re-tested locally and on the link, it does focus on the uploaded file. |
|
📖 The updated storybook is available here |
|
Collaborator
|
This issue is now working as expected hence we are good to close it related bug. Attachment - Untitled.video.-.Made.with.Clipchamp.22.mp4 |
Mnickii
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3110
PR Type
Description of the changes
Created custom events to be fired on successful or failed file upload attempts
Focus on the uploaded file
Set aria-label text to narrate the file name and status of upload
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information