Skip to content

fix(a11y): announce expanded/collapsed state of options menu in mgt-planner#3186

Merged
Mnickii merged 6 commits intomainfrom
fix/bug-3134
May 29, 2024
Merged

fix(a11y): announce expanded/collapsed state of options menu in mgt-planner#3186
Mnickii merged 6 commits intomainfrom
fix/bug-3134

Conversation

@Mnickii
Copy link
Copy Markdown
Collaborator

@Mnickii Mnickii commented May 22, 2024 •
edited
Loading

Closes #3134

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner May 22, 2024 17:13
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service Bot commented May 22, 2024

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2024

📖 The updated storybook is available here

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2024

📖 The updated storybook is available here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2024

📖 The updated storybook is available here

@Mnickii
Copy link
Copy Markdown
Collaborator Author

Mnickii commented May 23, 2024

@Raisul123 @vagpt Hi, please confirm that this fixes the narrator issues

musale
musale previously approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the added tokens, when you hover on the button the background changes correctly:
image

However, when you hover on the button on the text, the text background is still maintained:
image

You need to update the background color on the text portion for consistency.

@musale musale self-requested a review May 23, 2024 10:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2024

📖 The updated storybook is available here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

📖 The updated storybook is available here

@Mnickii
Copy link
Copy Markdown
Collaborator Author

Mnickii commented May 29, 2024

@Raisul123 @vagpt Hi, please confirm that this fixes the narrator issues

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

📖 The updated storybook is available here

@vagpt
Copy link
Copy Markdown
Collaborator

vagpt commented May 29, 2024

This issue is still repro on the URL below -

https://mgt.dev/next/pr/3186

Attachment:

issue.not.fixed.mp4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

📖 The updated storybook is available here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

📖 The updated storybook is available here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

📖 The updated storybook is available here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 82% 100% 0 ✔
mgt-components.src.components.mgt-person-card 77% 49% 0 ✔
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 78% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 27% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 90% 72% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 73% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 68% 71% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 84% 100% 0 ✔
mgt-element.src.utils 72% 91% 0 ➖
Summary 67% (14552 / 21576) 74% (520 / 702) 0 ➖

@vagpt
Copy link
Copy Markdown
Collaborator

vagpt commented May 29, 2024

Now, this issue is working fine on the URL below, hence closing this issue.

Attachment:

Now.announcing.the.state.mp4

@Mnickii Mnickii requested review from a team and gavinbarron May 29, 2024 14:09
@Mnickii Mnickii merged commit 6e51044 into main May 29, 2024
@Mnickii Mnickii deleted the fix/bug-3134 branch May 29, 2024 15:52
@gavinbarron gavinbarron mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Accessibility Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

3 participants

@Mnickii @vagpt @musale